chore: add docs for model level parameters #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeRego
reviewed
Aug 14, 2025
ZeRego
reviewed
Aug 14, 2025
ZeRego
reviewed
Aug 14, 2025
There was a problem hiding this comment.
Don't merge this under we figure out the problem when model has references to another model with parametes.
Slack thread: https://lightdash.slack.com/archives/C08N5JUL57V/p1755179277199939
ZeRego
requested changes
Aug 14, 2025
There was a problem hiding this comment.
Don't merge this under we figure out the problem when model has references to another model with parametes.
Slack thread: https://lightdash.slack.com/archives/C08N5JUL57V/p1755179277199939
Co-authored-by: Jose Rego <[email protected]>
Co-authored-by: Jose Rego <[email protected]>
almeidabbm
force-pushed
the
chore/add-docs-for-model-parameters
branch
from
b7fa3e1 to
4156be2
Compare
ZeRego
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #130
Related ticket: lightdash/lightdash#16297